Is this a good outfit for school?

It's alright, but black on black is difficult to pull off, especially with such bright shoes and trousers. (And don't wear an undershirt as a shirt. Try GAP, American Apparel, or Old Navy for v-necks.) If you really want to do black-on-black, try some dark 511s instead of khakis, and black Vans.